Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO in ws createMask #584

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Remove TODO in ws createMask #584

merged 1 commit into from
Sep 4, 2019

Conversation

Mark1626
Copy link
Contributor

@Mark1626 Mark1626 commented Sep 4, 2019

Refactor code to use crypto.getRandomValues and remove TODO

ry
ry approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit bc7dd39 into denoland:master Sep 4, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@Mark1626 @ry
ws: use crypto getRandomValues (denoland/std#584)
7213d9c 
Original: denoland/std@bc7dd39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mark1626 @ry